Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755173AbbFTQbP (ORCPT ); Sat, 20 Jun 2015 12:31:15 -0400 Received: from www.linutronix.de ([62.245.132.108]:32838 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753381AbbFTQbH (ORCPT ); Sat, 20 Jun 2015 12:31:07 -0400 Date: Sat, 20 Jun 2015 18:30:52 +0200 (CEST) From: Thomas Gleixner To: Andy Lutomirski cc: walter harms , Andy Lutomirski , X86 ML , Borislav Petkov , Peter Zijlstra , John Stultz , "linux-kernel@vger.kernel.org" , Len Brown , Huang Rui , Denys Vlasenko , kvm list , Ralf Baechle , Thomas Sailer , linux-hams@vger.kernel.org Subject: Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc() In-Reply-To: Message-ID: References: <1195ce0c7f34169ff3006341b77806184a46b9bf.1434501121.git.luto@kernel.org> <55857078.8060504@bfs.de> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 30 On Sat, 20 Jun 2015, Andy Lutomirski wrote: > On Sat, Jun 20, 2015 at 7:14 AM, Thomas Gleixner wrote: > > On Sat, 20 Jun 2015, walter harms wrote: > > > >> Acked-by: walter harms > >> > >> Am 17.06.2015 02:35, schrieb Andy Lutomirski: > >> > This is only used if BAYCOM_DEBUG is defined. > > > > So why don't we just replace that by ktime_get() and get rid of the > > x86'ism in that driver. > > > > I don't have the hardware, and I don't see any good reason to make an > rdtsc cleanup depend on a more complicated driver change. On the > other hand, if the maintainers want to clean it up, I think it would > be a great idea. > > This really seems to be debugging code, though. A normal kernel won't > even compile it. Right, but there is no reason that we have rdtsc outside of arch/x86 at all. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/