Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932707AbbFTVo3 (ORCPT <rfc822;w@1wt.eu>);
	Sat, 20 Jun 2015 17:44:29 -0400
Received: from mail-la0-f47.google.com ([209.85.215.47]:36721 "EHLO
	mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932611AbbFTVoV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 20 Jun 2015 17:44:21 -0400
MIME-Version: 1.0
In-Reply-To: <1434827273-13929-6-git-send-email-Julia.Lawall@lip6.fr>
References: <1434827273-13929-1-git-send-email-Julia.Lawall@lip6.fr>
	<1434827273-13929-6-git-send-email-Julia.Lawall@lip6.fr>
Date: Sat, 20 Jun 2015 23:44:19 +0200
Message-ID: <CAGhQ9VwuaSdEFj_X2=_re=A2kHh8NqhmMVOLTc9X8LOifLAUWw@mail.gmail.com>
Subject: Re: [PATCH 5/5] staging: lustre: osc: drop trivially useless initialization
From: Joachim Eastwood <manabian@gmail.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Oleg Drokin <oleg.drokin@intel.com>, kernel-janitors@vger.kernel.org,
        Andreas Dilger <andreas.dilger@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1283
Lines: 50

On 20 June 2015 at 21:07, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> Remove initialization of a variable that is immediately reassigned.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> type T;
> identifier x;
> constant C;
> expression e;
> @@
>
> T x
> - = C
>  ;
> x = e;
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
>  drivers/staging/lustre/lustre/osc/osc_page.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -u -p a/drivers/staging/lustre/lustre/osc/osc_page.c b/drivers/staging/lustre/lustre/osc/osc_page.c
> --- a/drivers/staging/lustre/lustre/osc/osc_page.c
> +++ b/drivers/staging/lustre/lustre/osc/osc_page.c
> @@ -471,7 +471,7 @@ static int osc_page_flush(const struct l
>                           struct cl_io *io)
>  {
>         struct osc_page *opg = cl2osc_page(slice);
> -       int rc = 0;
> +       int rc;
>
>         rc = osc_flush_async_page(env, io, opg);
>         return rc;
>

The whole rc variable is kinda useless.

Why not make it just:
return osc_flush_async_page(env, io, opg);

regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/