Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755593AbbFUARY (ORCPT ); Sat, 20 Jun 2015 20:17:24 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:39393 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754526AbbFUARR (ORCPT ); Sat, 20 Jun 2015 20:17:17 -0400 Message-ID: <5586027E.50304@collabora.co.uk> Date: Sun, 21 Jun 2015 02:17:02 +0200 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Paul Gortmaker , linux-kernel@vger.kernel.org CC: Lee Jones , Heiko Stuebner , Olof Johansson , Samuel Ortiz Subject: Re: [PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM References: <1434844916-5412-1-git-send-email-paul.gortmaker@windriver.com> In-Reply-To: <1434844916-5412-1-git-send-email-paul.gortmaker@windriver.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1798 Lines: 56 Hello Paul, On 06/21/2015 02:01 AM, Paul Gortmaker wrote: > In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec: > Move protocol helpers out of the MFD driver") there was a select > added on CHROME_PLATFORMS, which leads to the following for ppc/mips: > > warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet > direct dependencies (X86 || ARM) > Right, sorry for missing that and thank a lot for taking care of it. > Presumably the above means MFD_CROS_EC is only currently useful > on x86 and ARM, so lets limit it to there. > That is correct, although I wonder if CHROME_PLATFORMS should not also depend on || COMPILE_TEST and same for MFD_CROS_EC so those have at least build coverage on other architectures. I can't think for a reason to not be buildable on other archs... > Cc: Lee Jones > Cc: Javier Martinez Canillas > Cc: Heiko Stuebner > Cc: Olof Johansson > Cc: Samuel Ortiz > Signed-off-by: Paul Gortmaker > --- > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 653815950aa2..d3235e6f1953 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -94,6 +94,7 @@ config MFD_AXP20X > > config MFD_CROS_EC > tristate "ChromeOS Embedded Controller" > + depends on X86 || ARM > select MFD_CORE > select CHROME_PLATFORMS > select CROS_EC_PROTO > ...but that is orthogonal to this patch so: Acked-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/