Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932360AbbFUHXJ (ORCPT ); Sun, 21 Jun 2015 03:23:09 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:35095 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751394AbbFUHXC (ORCPT ); Sun, 21 Jun 2015 03:23:02 -0400 MIME-Version: 1.0 In-Reply-To: <1434542383-21314-1-git-send-email-yamada.masahiro@socionext.com> References: <1434542383-21314-1-git-send-email-yamada.masahiro@socionext.com> From: Alexandre Courbot Date: Sun, 21 Jun 2015 16:22:42 +0900 Message-ID: Subject: Re: [PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix memory leak To: Masahiro Yamada Cc: "linux-gpio@vger.kernel.org" , Linus Walleij , Linux Kernel Mailing List , Tien Hock Loh Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 571 Lines: 14 On Wed, Jun 17, 2015 at 8:59 PM, Masahiro Yamada wrote: > This driver calls of_mm_gpiochip_add() to add a memory mapped gpio > chip. So, of_mm_gpiochip_remove() should be used when removing it. > > The direct call of gpiochip_remove() misses unmapping the register > and freeing the label. > > Signed-off-by: Masahiro Yamada Reviewed-by: Alexandre Courbot -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/