Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755473AbbFUKN4 (ORCPT ); Sun, 21 Jun 2015 06:13:56 -0400 Received: from verein.lst.de ([213.95.11.211]:38442 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbbFUKNs (ORCPT ); Sun, 21 Jun 2015 06:13:48 -0400 Date: Sun, 21 Jun 2015 12:13:46 +0200 From: Christoph Hellwig To: Dan Williams Cc: axboe@kernel.dk, linux-nvdimm@ml01.01.org, boaz@plexistor.com, toshi.kani@hp.com, linux-kernel@vger.kernel.org, hch@lst.de, linux-acpi@vger.kernel.org, linux-fsdevel@vger.kernel.org, mingo@kernel.org Subject: Re: [PATCH 14/15] libnvdimm: support read-only btt backing devices Message-ID: <20150621101346.GF5915@lst.de> References: <20150617235209.12943.24419.stgit@dwillia2-desk3.amr.corp.intel.com> <20150617235602.12943.24958.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150617235602.12943.24958.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 767 Lines: 14 On Wed, Jun 17, 2015 at 07:56:02PM -0400, Dan Williams wrote: > Upon detection of a read-only backing device arrange for the btt to > device to be read only. Implement a catch for the BLKROSET ioctl and > only allow a btt-instance to become read-write when the backing-device > becomes read-write. Conversely, if a backing-device becomes read-only > arrange for its parent btt to be marked read-only. Synchronize these > changes under the bus lock. Eww. I have to say the deeper I look into this code the more I hate the stacking nature of btt. It seems more and more we should never attach pmem if we want to use a device with btt. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/