Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755153AbbFUN2y (ORCPT ); Sun, 21 Jun 2015 09:28:54 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35308 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752585AbbFUN2p (ORCPT ); Sun, 21 Jun 2015 09:28:45 -0400 MIME-Version: 1.0 In-Reply-To: <20150621100801.GC5915@lst.de> References: <20150617235209.12943.24419.stgit@dwillia2-desk3.amr.corp.intel.com> <20150617235541.12943.86562.stgit@dwillia2-desk3.amr.corp.intel.com> <20150621100801.GC5915@lst.de> Date: Sun, 21 Jun 2015 06:28:43 -0700 Message-ID: Subject: Re: [PATCH 10/15] libnvdimm: fix up max_hw_sectors From: Dan Williams To: Christoph Hellwig Cc: Jens Axboe , "linux-nvdimm@lists.01.org" , Boaz Harrosh , "Kani, Toshimitsu" , Vishal Verma , "linux-kernel@vger.kernel.org" , Linux ACPI , linux-fsdevel , Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 630 Lines: 16 On Sun, Jun 21, 2015 at 3:08 AM, Christoph Hellwig wrote: >> +void nd_blk_queue_init(struct request_queue *q) >> +{ >> + blk_queue_max_hw_sectors(q, UINT_MAX); >> + blk_queue_bounce_limit(q, BLK_BOUNCE_ANY); >> +} > > Please just add the calls to the drivers instead of this helper which > hides the intent. I thought it made it clearer what properties are shared between block devices on an nvdimm bus, but if you're initial reaction is that it hides intent I'll kill the helper. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/