Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755304AbbFUNbu (ORCPT ); Sun, 21 Jun 2015 09:31:50 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:38907 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752498AbbFUNbj (ORCPT ); Sun, 21 Jun 2015 09:31:39 -0400 MIME-Version: 1.0 In-Reply-To: <20150621100535.GB5915@lst.de> References: <20150617235209.12943.24419.stgit@dwillia2-desk3.amr.corp.intel.com> <20150617235508.12943.25057.stgit@dwillia2-desk3.amr.corp.intel.com> <20150621100535.GB5915@lst.de> Date: Sun, 21 Jun 2015 06:31:38 -0700 Message-ID: Subject: Re: [PATCH 04/15] libnvdimm, nfit, nd_blk: driver for BLK-mode access persistent memory From: Dan Williams To: Christoph Hellwig Cc: Jens Axboe , "linux-nvdimm@lists.01.org" , Boaz Harrosh , "Kani, Toshimitsu" , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Andy Lutomirski , Jens Axboe , Linux ACPI , "H. Peter Anvin" , linux-fsdevel , Ross Zwisler , Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1411 Lines: 29 On Sun, Jun 21, 2015 at 3:05 AM, Christoph Hellwig wrote: >> +#include > > As mentioned last time only arch asm/ headers may include asm-generic > headers. No, not in this case, there's no other way to define readq()/writeq() on 32-bit builds. See: drivers/block/nvme-core.c:43:#include drivers/edac/i3200_edac.c:18:#include drivers/edac/ie31200_edac.c:42:#include drivers/edac/x38_edac.c:18:#include drivers/i2c/busses/i2c-ismt.c:70:#include drivers/net/ethernet/intel/i40e/i40e_osdep.h:38:#include drivers/net/ethernet/intel/i40evf/i40e_osdep.h:37:#include drivers/net/ethernet/rocker/rocker.c:39:#include drivers/platform/x86/ibm_rtl.c:36:#include drivers/platform/x86/intel_ips.c:81:#include drivers/scsi/qla4xxx/ql4_nx.c:15:#include The only other option is to open code multiple readl() + writel() calls. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/