Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755972AbbFUN4S (ORCPT ); Sun, 21 Jun 2015 09:56:18 -0400 Received: from verein.lst.de ([213.95.11.211]:38950 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753836AbbFUN4J (ORCPT ); Sun, 21 Jun 2015 09:56:09 -0400 Date: Sun, 21 Jun 2015 15:56:06 +0200 From: Christoph Hellwig To: Dan Williams Cc: Christoph Hellwig , Jens Axboe , "linux-nvdimm@lists.01.org" , Boaz Harrosh , "Kani, Toshimitsu" , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Andy Lutomirski , Jens Axboe , Linux ACPI , "H. Peter Anvin" , linux-fsdevel , Ross Zwisler , Ingo Molnar Subject: Re: [PATCH 04/15] libnvdimm, nfit, nd_blk: driver for BLK-mode access persistent memory Message-ID: <20150621135606.GB9572@lst.de> References: <20150617235209.12943.24419.stgit@dwillia2-desk3.amr.corp.intel.com> <20150617235508.12943.25057.stgit@dwillia2-desk3.amr.corp.intel.com> <20150621100535.GB5915@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 18 On Sun, Jun 21, 2015 at 06:31:38AM -0700, Dan Williams wrote: > > As mentioned last time only arch asm/ headers may include asm-generic > > headers. > > No, not in this case, there's no other way to define readq()/writeq() > on 32-bit builds. See: Oh my god. I think we're both right: no driver should use asm-generic, but because someone totally messed this abstraction up you have no choice. We really should have a linux/*.h header for these that just does the right thing. Btw, what's the reason you're using the hi-lo ordering unlikely everyone else? IMHO that should be an arch and not a driver choice. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/