Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755967AbbFUN5w (ORCPT ); Sun, 21 Jun 2015 09:57:52 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:33437 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753969AbbFUN5o (ORCPT ); Sun, 21 Jun 2015 09:57:44 -0400 MIME-Version: 1.0 In-Reply-To: <557D5562.8020209@kernel.org> References: <20150611120635.GA15709@Inspiron> <557D5562.8020209@kernel.org> Date: Sun, 21 Jun 2015 16:57:43 +0300 X-Google-Sender-Auth: iIlg_c6L8avehKWS5CSjTlgrMkw Message-ID: Subject: Re: [PATCH] iio: Fix parameters in iio_triggered_buffer_setup From: Daniel Baluta To: Jonathan Cameron , Lars-Peter Clausen Cc: Cristina Opriceana , Peter Meerwald , "linux-iio@vger.kernel.org" , Linux Kernel Mailing List , Daniel Baluta , "octavian.purdila@intel.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1002 Lines: 23 On Sun, Jun 14, 2015 at 1:20 PM, Jonathan Cameron wrote: > On 11/06/15 13:06, Cristina Opriceana wrote: >> This patch renames the top half handler and the bottom half handler >> of iio_triggered_buffer_setup() in accordance with their usage. >> The names of the parameters were swapped, thus creating confusion. >> >> Signed-off-by: Cristina Opriceana > Good point. This is definitely misleading. I wonder if the _th naming > is a good idea anymore though given that the bottom half (in the traditional > sense) is now a thread based call and hence the th might be confusing? > Perhaps the h and thread naming used in the pollfunc code would be clearer? > Sounds like a good idea. Cristina can prepare a patch for this. > Lars, this bit was yours originally. Any thoughts? Lets wait for Lars thoughts on this. Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/