Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755803AbbFUQKp (ORCPT ); Sun, 21 Jun 2015 12:10:45 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:46302 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751909AbbFUQKg (ORCPT ); Sun, 21 Jun 2015 12:10:36 -0400 Date: Sun, 21 Jun 2015 09:22:18 -0700 (PDT) Message-Id: <20150621.092218.2158342160706463595.davem@davemloft.net> To: noamc@ezchip.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey.Brodkin@synopsys.com, vgupta@synopsys.com, giladb@ezchip.com, cmetcalf@ezchip.com, talz@ezchip.com Subject: Re: [PATCH v5] NET: Add ezchip ethernet driver From: David Miller In-Reply-To: <1434465342-7412-1-git-send-email-noamc@ezchip.com> References: <1434263193-16877-1-git-send-email-noamc@ezchip.com> <1434465342-7412-1-git-send-email-noamc@ezchip.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 21 Jun 2015 09:10:35 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t5LGAs8T001472 Content-Length: 1718 Lines: 31 From: Noam Camus Date: Tue, 16 Jun 2015 17:35:42 +0300 > From: Noam Camus > > Simple LAN device for debug or management purposes. > Device supports interrupts for RX and TX(completion). > Device does not have DMA ability. > > Signed-off-by: Noam Camus > Signed-off-by: Tal Zilcer > Acked-by: Alexey Brodkin This builds with several warnings and also doesn't compile. drivers/net/ethernet/ezchip/nps_enet.c: In function ?nps_enet_read_rx_fifo?: drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/net/ethernet/ezchip/nps_enet.c: In function ?nps_enet_send_frame?: drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/net/ethernet/ezchip/nps_enet.c: In function ?nps_enet_poll_controller?: drivers/net/ethernet/ezchip/nps_enet.c:535:2: error: implicit declaration of function ?nps_enet_board_irq_handler? [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors I do not even see where npe_enet_board_irq_handler could possible be defined. It is quite infuriating to receive a patch like this which is claimed to be complete and ready to be applied to my tree, yet it is very clearly not. ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????s?y??杶????i??????????i