Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755711AbbFUSHV (ORCPT ); Sun, 21 Jun 2015 14:07:21 -0400 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:19335 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbbFUSHN (ORCPT ); Sun, 21 Jun 2015 14:07:13 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 21 Jun 2015 20:07:12 +0200 X-ME-IP: 109.222.196.159 From: Robert Jarzmik To: Guennadi Liakhovetski Cc: Mauro Carvalho Chehab , Jiri Kosina , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Mack , Robert Jarzmik Subject: Re: [PATCH 3/4] media: pxa_camera: trivial move of dma irq functions References: <1426980085-12281-1-git-send-email-robert.jarzmik@free.fr> <1426980085-12281-4-git-send-email-robert.jarzmik@free.fr> <87y4je831c.fsf@belgarion.home> X-URL: http://belgarath.falguerolles.org/ Date: Sun, 21 Jun 2015 20:05:06 +0200 In-Reply-To: (Guennadi Liakhovetski's message of "Sun, 21 Jun 2015 18:11:26 +0200 (CEST)") Message-ID: <87k2ux7x9p.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1029 Lines: 30 Guennadi Liakhovetski writes: > On Sat, 20 Jun 2015, Robert Jarzmik wrote: > >> Guennadi Liakhovetski writes: >> >> >> +static void pxa_camera_dma_irq(struct pxa_camera_dev *pcdev, >> >> + enum pxa_camera_active_dma act_dma); >> >> + >> >> +static void pxa_camera_dma_irq_y(void *data) >> > >> > Wait, how is this patch trivial? You change pxa_camera_dma_irq_?() >> > prototypes, which are used as PXA DMA callbacks. Does this mean, that >> > either before or after this patch compilation is broken? >> >> Jeez you're right. >> So I can either fold that with patch 4, or try to rework it somehow ... > > How about letting that patch do exactly what it says it does? Just move > functions up in the file if you need them there, without changing them, > and only change them when it's needed? Deal, for next iteration. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/