Date: Mon, 22 Jun 2015 03:47:40 +0000 (GMT)
From: Maninder Singh <maninder1.s@samsung.com>
Subject: Re: [PATCH 1/1] ssb: remove unncessary out label
To: =?windows-1252?Q?Michael_B=3Fch?= <m@bues.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        PANKAJ MISHRA <pankaj.m@samsung.com>
Reply-to: maninder1.s@samsung.com
MIME-version: 1.0
Msgkey: 20150622034340939@maninder1.s
Content-type: text/plain; charset=windows-1252
MIME-version: 1.0
Message-id: <764435082.28361434944858940.JavaMail.weblogic@ep2mlwas07a>
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 565
Lines: 23

Hi Michael,

>>  	pdev = bus->host_pci;
>>  	mutex_init(&bus->sprom_mutex);
>> -	err = device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
>> -	if (err)
>> -		goto out;
>> -
>> -out:
>> -	return err;
>> +	return device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
>>  }
>
>
>I don't really think this change adds any value, but if you insist on
>it you get my acked-by.

Yes You are right, But By this change code looks simpler.
Thats why i suggested the changes.

Thanks
Maninder
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????s?y??杶????i??????????i