Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753802AbbFVEpe (ORCPT ); Mon, 22 Jun 2015 00:45:34 -0400 Received: from mail2.asahi-net.or.jp ([202.224.39.198]:20502 "EHLO mail2.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbbFVEp1 (ORCPT ); Mon, 22 Jun 2015 00:45:27 -0400 X-Greylist: delayed 1156 seconds by postgrey-1.27 at vger.kernel.org; Mon, 22 Jun 2015 00:45:26 EDT Date: Mon, 22 Jun 2015 13:26:01 +0900 Message-ID: <87381ktlly.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Rob Landley Cc: Geert Uytterhoeven , Jiri Slaby , Andrew Morton , Geert Uytterhoeven , Kevin Hilman , "Rafael J. Wysocki" , Vivek Goyal , "Steven Rostedt (Red Hat)" , "Kirill A. Shutemov" , Riku Voipio , Jiri Kosina , Paul Bolle , Ingo Molnar , Peter Zijlstra , Davidlohr Bueso , Richard Weinberger , Zhigang Lu , Vineet Gupta , Richard Kuo , Max Filippov , Pranith Kumar , Linux-sh list , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" Subject: Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board. In-Reply-To: <5585C952.6020406@landley.net> References: <1434647946.861556@landley.net> <1434647946.861922@landley.net> <55849397.1060000@landley.net> <5585C952.6020406@landley.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4282 Lines: 105 On Sun, 21 Jun 2015 05:13:06 +0900, Rob Landley wrote: > > On 06/20/2015 03:00 AM, Geert Uytterhoeven wrote: > > Hi Rob, > > > > On Sat, Jun 20, 2015 at 12:11 AM, Rob Landley wrote: > >> On 06/18/2015 02:36 PM, Geert Uytterhoeven wrote: > >>> On Thu, Jun 18, 2015 at 7:19 PM, Rob Landley wrote: > >>>> Changes to existing files to add 0pf j2 board support. > >>> > >>> Thanks for your patch! > >>> > >>> Like Greg already said, splitting it up in logical parts and providing useful > >>> patch descriptions would be highly appreciated. > >> > >> I actually don't know how to split it up further. The initial port was > >> done by a series of contractors (in Russia, I think), and then I > >> inherited it to try to get something releasable. This is the smallest > >> chunk I could get to actually boot. > >> > >> I suppose I could send you the serial driver by itself, and _then_ the > >> board, but it wouldn't compile if nothing uses it. (Similarly you can't > >> boot the board without a serial console...) > > > > You don't have to send in a big initial patch that actually boots. > > For new architecture/SoC/board support, just split it in logical hunks, > > and submit it in some logical order that always builds. > > > > E.g.: > > - SoC core support (arch/sh/), > > - Board support (arch/sh/), > > - Drivers. > > > > The first two should go in through akpm (sh is orphaned), > > the rest through the individual subsystem maintainers. > > I'm aware sh is orphaned > (http://www.openwall.com/lists/musl/2014/02/17/3). I'm trying to do > something about that. > > I'm not up to maintaining an architecture myself (after the > kernel.org/doc thing I walked away from kernel stuff for most of a year, > as you can see I'm a bit out of practice), but I spoke to Yoshinori Sato > (who used to maintain sh2, and only dropped it when renesas discontinued > the hardware) and he said he might be interested in returning as a > co-maintainer. > > (I note that I've been regression testing and fixing sh4 in my > aboriginal linux project for several years now, although it's been > quiescent enough on the kernel side the majority of my posts about it > seem to be qemu issues, from > https://lists.gnu.org/archive/html/qemu-devel/2010-03/msg00976.html to > http://comments.gmane.org/gmane.comp.emulators.qemu/294066 . Dealing > with sh2 is new to me, but it's also my day job these days. :) > > >> (Now the reason _I_ thought you'd reject it had more to do with not > >> having converted it to device tree yet, and things on that level. But I > > > > Sh is an existing supported architecture, so DT is not a hard requirement. > > Yeah, but new board... And it's the right thing to do. I think convert DT is best way. It looks don't use SH compatible peripherals. I think if it's a SH compatible, it's better to maintain the platform_device structure. But use incompatible peripherals (So need new platform_device), It's difficult to maintain it. I trying SE7619 target convert to DT. It works fine. So no problem in 0PF platform DT support. > > If you would have waited until after the removal of sh, it would be much > > harder :-) (cfr. h8300, but Sato-san did a great job there, with DT, CCF, ...) > > Indeed he did. We had lunch with him when I was in Japan a couple weeks ago. > > I've got the references I need to do this, just... lots of shoveling on > a lot of fronts to do right now. (And I mentioned like 3 other things I > already know I need to fix in the 0/2 message.) > > >> wanted to get it out there so people outside $DAYJOB can test the > >> hardware. We did a linuxcon japan presentation which lwn.net covered, > >> and we're getting pokes about "where can I download this", so...) > > > > It's great to hear there's so much interest in this! Let's hope this will > > attract more actual contributors... > > The "where can I download this" is now the developer tab of 0pf.org by > the way. And the mailing lists are on lists.nommu.org. > > I'll try to submit an updated patch set in the next couple days. > > Thanks, > > Rob -- Yoshinori Sato -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/