Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932923AbbFVGdK (ORCPT ); Mon, 22 Jun 2015 02:33:10 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:33297 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754188AbbFVGcw (ORCPT ); Mon, 22 Jun 2015 02:32:52 -0400 MIME-Version: 1.0 In-Reply-To: <1434944170.25921.6.camel@mtksdaap41> References: <1434553683-11651-1-git-send-email-eddie.huang@mediatek.com> <1434553683-11651-3-git-send-email-eddie.huang@mediatek.com> <1434944170.25921.6.camel@mtksdaap41> From: Daniel Kurtz Date: Mon, 22 Jun 2015 14:32:32 +0800 X-Google-Sender-Auth: pAwVNmbckay_TspOgEOZygi_gV0 Message-ID: Subject: Re: [PATCH v4 2/2] arm64: dts: mt8173: Add I2C device node To: Eddie Huang Cc: Matthias Brugger , Sascha Hauer , "open list:OPEN FIRMWARE AND..." , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5279 Lines: 114 On Mon, Jun 22, 2015 at 11:36 AM, Eddie Huang wrote: > Hi Dan, > > On Thu, 2015-06-18 at 23:16 +0800, Daniel Kurtz wrote: >> On Wed, Jun 17, 2015 at 11:08 PM, Eddie Huang wrote: >> > Add MT8173 I2C device nodes, include I2C controllers and pins. >> > MT8173 has six I2C controllers, from i2c0 to i2c6, exclude i2c5. >> > The 6th I2C controller register base doesn't next to 5th I2C, >> > and there is a hardware between 5th and 6th I2C controller. So >> > SoC designer name 6th controller as "i2c6", not "i2c5". >> > >> > Signed-off-by: Eddie Huang >> > --- >> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 144 +++++++++++++++++++++++++++++++ >> > 1 file changed, 144 insertions(+) >> > >> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> > index b52ec43..1816c8f 100644 >> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> > @@ -158,6 +158,54 @@ >> > interrupts = , >> > , >> > ; >> > + >> > + i2c0_pins_a: i2c0 { >> > + pins1 { >> > + pinmux = , >> > + ; >> > + bias-disable; >> > + }; >> > + }; >> > + >> > + i2c1_pins_a: i2c1 { >> > + pins1 { >> > + pinmux = , >> > + ; >> > + bias-disable; >> > + }; >> > + }; >> > + >> > + i2c2_pins_a: i2c2 { >> > + pins1 { >> > + pinmux = , >> > + ; >> > + bias-disable; >> > + }; >> > + }; >> > + >> > + i2c3_pins_a: i2c3 { >> > + pins1 { >> > + pinmux = , >> > + ; >> > + bias-disable; >> > + }; >> > + }; >> > + >> > + i2c4_pins_a: i2c4 { >> > + pins1 { >> > + pinmux = , >> > + ; >> > + bias-disable; >> > + }; >> > + }; >> > + >> > + i2c6_pins_a: i2c6 { >> > + pins1 { >> > + pinmux = , >> > + ; >> > + bias-disable; >> > + }; >> > + }; >> > }; >> > >> > watchdog: watchdog@10007000 { >> > @@ -229,6 +277,102 @@ >> > clocks = <&uart_clk>; >> > status = "disabled"; >> > }; >> > + >> > + i2c0: i2c@11007000 { >> > + compatible = "mediatek,mt8173-i2c"; >> > + reg = <0 0x11007000 0 0x70>, >> > + <0 0x11000100 0 0x80>; >> > + interrupts = ; >> > + clock-div = <16>; >> >> According to the i2c-mt6577 dt binding: >> - clock-div: the fixed value for frequency divider of clock source in i2c >> module. Each IC may be different. >> >> For other drivers I've seen this kind of hardware-specific value >> implemented as a table in the driver that is indexed based on the >> compatible. >> >> Any particular reason to specify it here in every device tree node instead? >> > > If put in device tree, it is not necessary to add new compatible if new > SoC has the same I2C controller hardware except clock-div.The benefit is > keep driver clean, but the side-effect is add clock-div in device node.I > assume clock-div has the same concept of clock, so I put in device tree. Sounds reasonable to me. This patch is: Reviewed-by: Daniel Kurtz > Eddie > Thanks > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/