Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932410AbbFVG6M (ORCPT ); Mon, 22 Jun 2015 02:58:12 -0400 Received: from webbox1416.server-home.net ([77.236.96.61]:43552 "EHLO webbox1416.server-home.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752636AbbFVG6E (ORCPT ); Mon, 22 Jun 2015 02:58:04 -0400 X-Greylist: delayed 553 seconds by postgrey-1.27 at vger.kernel.org; Mon, 22 Jun 2015 02:58:03 EDT From: Alexander Stein To: Manfred Schlaegl Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Manfred Schlaegl Subject: Re: [PATCH] serial: imx: reduce irq-latency after rx overflow Date: Mon, 22 Jun 2015 08:48:44 +0200 Message-ID: <4275820.CIOTxUBfmF@ws-stein> User-Agent: KMail/4.14.8 (Linux/4.0.5-gentoo; KDE/4.14.8; x86_64; ; ) In-Reply-To: <5585A220.5000405@gmx.at> References: <5585A220.5000405@gmx.at> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1425 Lines: 35 Am Samstag, 20. Juni 2015, 19:25:52 schrieb Manfred Schlaegl: > To prevent problems with interrupt latency, and due to the fact, that > the error will be counted anyway (icount.overrun), the dev_err is simply > removed. > > Background: > If an rx-fifo overflow occurs a dev_err message was called in interrupt > context. Since dev_err messages are written to console in a synchronous way > (unbuffered), and console may be a serial terminal, this leads to a > highly increased interrupt-latency (several milliseconds). > As a result of the high latency more rx-fifo overflows will happen, and > therefore a feedback loop of errors is created. I understand your rationale but removing this error message from kernel log removes the possibility to detect serial overruns by simply check the kernel log or output on kernel console. AFAICS you have to use TIOCGICOUNT to get the error counters. How about introducing a rate limit for this kernel message? Best regards, Alexander -- Dipl.-Inf. Alexander Stein SYS TEC electronic GmbH Am Windrad 2 08468 Heinsdorfergrund Tel.: 03765 38600-1156 Fax: 03765 38600-4100 Email: alexander.stein@systec-electronic.com Website: www.systec-electronic.com Managing Director: Dipl.-Phys. Siegmar Schmidt Commercial registry: Amtsgericht Chemnitz, HRB 28082 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/