Date: Mon, 22 Jun 2015 06:53:07 +0000 (GMT)
From: Maninder Singh <maninder1.s@samsung.com>
Subject: Re: [RFC PATCH v2] packet: remove handling of tx_ring
To: Frans Klaver <fransklaver@gmail.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
        Willem de Bruijn <willemb@google.com>,
        "dborkman@redhat.com" <dborkman@redhat.com>,
        Alexander Drozdov <al.drozdov@gmail.com>,
        Al Viro <viro@zeniv.linux.org.uk>, Eyal Birger <eyal.birger@gmail.com>,
        "mst@redhat.com" <mst@redhat.com>, netdev <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        PANKAJ MISHRA <pankaj.m@samsung.com>
Reply-to: maninder1.s@samsung.com
MIME-version: 1.0
Msgkey: 20150622064440571@maninder1.s
Content-type: text/plain; charset=windows-1252
MIME-version: 1.0
Message-id: <1504484104.41691434955982414.JavaMail.weblogic@ep2mlwas07a>
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1333
Lines: 42

Hi Frans,

>> v1 = replace if()/BUG with BUG_ON() for tx_ring.
>>
>> v2 =
>
>I would keep this below the ---. There's little historical use for
>this version information when it gets merged.
>
>> remove handling of tx_ring in prb_setup_retire_blk_timer
>> for TPACKET_V3 because init_prb_bdqc is called only for NULL tx_ring
>> and thus prb_setup_retire_blk_timer for NULL tx_ring only.
>
>I'd say tx_ring is false, rather than NULL. It's not a pointer (here).
>
>
>> And also in funciton init_prb_bdqc there is no usage of tx_ring.
>
>s,funciton,function,

Thanks for feedback , please check below changelog if it looks ok,
Then i will share updated patch:-

v1 = replace if()/BUG with BUG_ON() for tx_ring.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Signed-off-by: Frans Klaver <fransklaver@gmail.com>
---
Changes in v2:

 Remove handling of tx_ring in prb_setup_retire_blk_timer
 for TPACKET_V3 because init_prb_bdqc is called only for zero tx_ring 
 and thus prb_setup_retire_blk_timer for zero tx_ring only.

 And also in functon init_prb_bdqc there is no usage of tx_ring.
 Thus removing tx_ring from init_prb_bdqc.

 net/packet/af_packet.c |   14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)
 
 Thanks
 Maninder????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????s?y??杶????i??????????i