Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933005AbbFVHa2 (ORCPT ); Mon, 22 Jun 2015 03:30:28 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:34644 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753591AbbFVHaV (ORCPT ); Mon, 22 Jun 2015 03:30:21 -0400 MIME-Version: 1.0 In-Reply-To: <1434622954-26747-3-git-send-email-geert+renesas@glider.be> References: <1434622954-26747-1-git-send-email-geert+renesas@glider.be> <1434622954-26747-3-git-send-email-geert+renesas@glider.be> Date: Mon, 22 Jun 2015 09:30:20 +0200 X-Google-Sender-Auth: OkCsdLn0fFQR5BJB8c1yyIMgP3s Message-ID: Subject: Re: [PATCH 2/2] PM / Domains: Avoid infinite loops in attach/detach code From: Geert Uytterhoeven To: Geert Uytterhoeven Cc: Daniel Lezcano , Thomas Gleixner , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Magnus Damm , Laurent Pinchart , Linux PM list , Linux-sh list , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1998 Lines: 57 On Thu, Jun 18, 2015 at 12:22 PM, Geert Uytterhoeven wrote: > If pm_genpd_{add,remove}_device() keeps on failing with -EAGAIN, we end > up with an infinite loop in genpd_dev_pm_{at,de}tach(). > > This may happen due to a genpd.prepared_count imbalance. This is a bug > elsewhere, but it will result in a system lock up, possibly during > reboot of an otherwise functioning system. > > To avoid this, put a limit on the maximum number of loop iterations, > including a simple back-off mechanism. If the limit is reached, the > operation will just fail. An error message is already printed. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/base/power/domain.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index cdd547bd67df8218..aa06f60b98b8af35 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2218,10 +2226,13 @@ int genpd_dev_pm_attach(struct device *dev) > > dev_dbg(dev, "adding to PM domain %s\n", pd->name); > > - while (1) { > + for (i = 0; i < GENPD_RETRIES; i++) { Sorry, there's a declaration of "i" missing. > ret = pm_genpd_add_device(pd, dev); > if (ret != -EAGAIN) > break; > + > + if (i > GENPD_RETRIES / 2) > + udelay(GENPD_DELAY_US); > cond_resched(); > } > > -- > 1.9.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/