Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933162AbbFVI0b (ORCPT ); Mon, 22 Jun 2015 04:26:31 -0400 Received: from smtp-out-131.synserver.de ([212.40.185.131]:1047 "EHLO smtp-out-131.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752819AbbFVI0X (ORCPT ); Mon, 22 Jun 2015 04:26:23 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 17212 Message-ID: <5587C6AB.8070903@metafoo.de> Date: Mon, 22 Jun 2015 10:26:19 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Daniel Baluta , Jonathan Cameron CC: Cristina Opriceana , Peter Meerwald , "linux-iio@vger.kernel.org" , Linux Kernel Mailing List , "octavian.purdila@intel.com" Subject: Re: [PATCH] iio: Fix parameters in iio_triggered_buffer_setup References: <20150611120635.GA15709@Inspiron> <557D5562.8020209@kernel.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1131 Lines: 25 On 06/21/2015 03:57 PM, Daniel Baluta wrote: > On Sun, Jun 14, 2015 at 1:20 PM, Jonathan Cameron wrote: >> On 11/06/15 13:06, Cristina Opriceana wrote: >>> This patch renames the top half handler and the bottom half handler >>> of iio_triggered_buffer_setup() in accordance with their usage. >>> The names of the parameters were swapped, thus creating confusion. >>> >>> Signed-off-by: Cristina Opriceana >> Good point. This is definitely misleading. I wonder if the _th naming >> is a good idea anymore though given that the bottom half (in the traditional >> sense) is now a thread based call and hence the th might be confusing? >> Perhaps the h and thread naming used in the pollfunc code would be clearer? >> > > Sounds like a good idea. Cristina can prepare a patch for this. > >> Lars, this bit was yours originally. Any thoughts? Jonathan, that's your naming convention I merely added the wrapper function. I'm OK with changing the naming. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/