Message-ID: <1434962926.19497.88.camel@x220>
Subject: Re: [PATCH] gpio: Add AMD SB8XX/SB9XX/A5X/A8X driver
From: Paul Bolle <pebolle@tiscali.nl>
To: Tobias Diedrich <ranma+kernel@tdiedrich.de>
Cc: linux-kernel@vger.kernel.org
Date: Mon, 22 Jun 2015 10:48:46 +0200
In-Reply-To: <20150620215753.GD29802@yumi.tdiedrich.de>
References: <20150620215753.GD29802@yumi.tdiedrich.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 863
Lines: 29

[Shouldn't gpio patches be sent to Linus Walleij, Alexandre Courbot, and
the linux-gpio list too?]

Just a nit: a license mismatch.

On Sat, 2015-06-20 at 23:57 +0200, Tobias Diedrich wrote:
> --- /dev/null
> +++ b/drivers/gpio/gpio-sb8xx.c

> + * This file is licensed under  the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.

This states the license is GPL v2.

> +MODULE_LICENSE("GPL");

And, according to include/linux/module.h, this states the license is GPL
v2 or later. So I think that either the comment at the top of this file
or the ident used in the MODULE_LICENSE() macro needs to change.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/