Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933204AbbFVKG2 (ORCPT ); Mon, 22 Jun 2015 06:06:28 -0400 Received: from lb3-smtp-cloud3.xs4all.net ([194.109.24.30]:46494 "EHLO lb3-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752786AbbFVKGW (ORCPT ); Mon, 22 Jun 2015 06:06:22 -0400 Message-ID: <1434967564.31094.20.camel@x220> Subject: Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver From: Paul Bolle To: Yakir Yang Cc: linux-rockchip@lists.infradead.org, alsa-devel , dri-devel , linux-kernel@vger.kernel.org, linux-arm-kernel , Doug Anderson , David Airlie , Philipp Zabel , Russell King , Andy Yan , Daniel Kurtz , Fabio Estevam , Mark Brown , Takashi Iwai , Jaroslav Kysela , Heiko Stuebner , Liam Girdwood Date: Mon, 22 Jun 2015 12:06:04 +0200 In-Reply-To: <1434731295-11060-1-git-send-email-ykk@rock-chips.com> References: <1434730417-10629-1-git-send-email-ykk@rock-chips.com> <1434731295-11060-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1487 Lines: 42 Something I didn't notice in v4, sorry. On Sat, 2015-06-20 at 00:28 +0800, Yakir Yang wrote: > --- /dev/null > +++ b/drivers/gpu/drm/bridge/dw_hdmi-i2s-audio.c > +#define DRIVER_NAME "dw-hdmi-i2s-audio" > +MODULE_ALIAS(PLATFORM_MODULE_PREFIX DRIVER_NAME); 0) Side note: this is the first time that PLATFORM_MODULE_PREFIX is used inside MODULE_ALIAS(). But none of the 1000+ other "platform:" aliases do that. And neither does 5/6 of this series! That suggests, I think, that this shouldn't be done. You could consider adding something like #define MODULE_ALIAS_PLATFORM(NAME) MODULE_ALIAS(PLATFORM_MODULE_PREFIX NAME) But then, I think, all the current 1000+ platform: aliases should be converted to that macro. Would that be worth it? 1) Now on to my remark: this alias seems to be only useful if there also is a struct platform_device with a "dw-hdmi-i2s-audio" name. Because that platform_device would, badly summarized, fire of a "MODALIAS=platform:dw-hdmi-i2s-audio" uevent when created. Which, in its turn, would trigger userspace to load this module, correct? But I think there's no platform_device with a "dw-hdmi-i2s-audio" name. So I wonder whether this MODULE_ALIAS() is actually needed. What breaks if you leave it out? (Likewise for 5/6, but there the platform_device should have a "rockchip-hdmi-audio" name.) Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/