Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755034AbbFVKdt (ORCPT ); Mon, 22 Jun 2015 06:33:49 -0400 Received: from senator.holtmann.net ([87.106.208.187]:39739 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752191AbbFVKdi convert rfc822-to-8bit (ORCPT ); Mon, 22 Jun 2015 06:33:38 -0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: [PATCH] Bluetooth: btusb: Add Realtek devices into module device table From: Marcel Holtmann In-Reply-To: <55860F8C.4050205@lwfinger.net> Date: Mon, 22 Jun 2015 12:33:34 +0200 Cc: Xi Ruoyao , "Gustavo F. Padovan" , Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Drake Content-Transfer-Encoding: 8BIT Message-Id: References: <55860F8C.4050205@lwfinger.net> To: Larry Finger X-Mailer: Apple Mail (2.2098) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2559 Lines: 50 Hi Larry, >>> In 'commit a2698a9bf9b0 ("Bluetooth: btusb: Add Realtek >>> 8723A/8723B/8761A/8821A support"), support of some Realtek >>> devices was added to the Generic Bluetooth USB driver in kernel. >>> However, these devices are not in the module device table of >>> btusb.ko, so the kernel wouldn't probe them at all. >>> >>> To fix this, add four entries in the device table btusb_table, >>> based on code from >>> ('new' branch). >>> >>> This enables bluetooth support in the Lenovo Ideapad Yoga 13 >>> which has RTL8723AU USB device, with product ID 0bda:1724. >>> >>> Signed-off-by: Xi Ruoyao >>> --- >>> drivers/bluetooth/btusb.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c >>> index 3c10d4d..dd87623 100644 >>> --- a/drivers/bluetooth/btusb.c >>> +++ b/drivers/bluetooth/btusb.c >>> @@ -148,6 +148,12 @@ static const struct usb_device_id btusb_table[] = { >>> { USB_DEVICE(0x8087, 0x0a5a), >>> .driver_info = BTUSB_INTEL_BOOT | BTUSB_BROKEN_ISOC }, >>> >>> + /* Realtek Bluetooth */ >>> + { USB_VENDOR_AND_INTERFACE_INFO(0x0bda, 0xe0, 0x01, 0x01) }, >>> + { USB_VENDOR_AND_INTERFACE_INFO(0x0bd5, 0xe0, 0x01, 0x01) }, >>> + { USB_VENDOR_AND_INTERFACE_INFO(0x13d3, 0xe0, 0x01, 0x01) }, >>> + { USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xe0, 0x01, 0x01) }, >>> + >> >> I highly doubt these are needed. There is a generic entry for an USB transport that is already covering these. > > Something changed in recent kernels, and the generic USB transport entries do not seem to be recognized in the case where a wifi and BT device share a single USB ID. As the OP's tablet has such a case, I suggest that 0bda line be accepted, but not the others. If I had a computer with an RTL8723AU, I would have a chance at debugging what changed, but sadly, that is not the case. these Realtek devices are causing the most messy setup in a generic driver. And Bluetooth USB support has been really clean and simple for the last 10 years. I really wonder how many ways this gets done wrong before someone gets a clue and gets this right. At the end of the day this USB transport is 15 years old. Anyway, for obvious reasons the content of /sys/kernel/debug/usb/devices should be included here so that someone can actually look at how the USB endpoints are configured. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/