Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933159AbbFVLj4 (ORCPT ); Mon, 22 Jun 2015 07:39:56 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:35568 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751843AbbFVLju (ORCPT ); Mon, 22 Jun 2015 07:39:50 -0400 Date: Mon, 22 Jun 2015 17:09:40 +0530 From: Sudip Mukherjee To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, Ian Abbott , H Hartley Sweeten , Greg Kroah-Hartman , Jaime Arrocha Subject: Re: [PATCH] staging: comedi: coding style fixes Message-ID: <20150622113940.GE3355@sudip-PC> References: <20150621202530.GA20452@turing> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150621202530.GA20452@turing> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 602 Lines: 18 On Sun, Jun 21, 2015 at 09:25:30PM +0100, Luis de Bethencourt wrote: > Warnings found by checkpatch.pl > > WARNING: please, no space before tabs > /drivers/staging/comedi/drivers/das16m1.c:83 > + 404-407 ^I8254$ > > WARNING: line over 80 characters > /drivers/staging/comedi/drivers/das16m1.c:414 > + if (devpriv->adc_count == 0 && hw_counter == devpriv->initial_hw_count) { That is two different type of changes. Please break them into separate patches. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/