Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756096AbbFVMCW (ORCPT <rfc822;w@1wt.eu>);
	Mon, 22 Jun 2015 08:02:22 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:32798 "EHLO
	mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933332AbbFVMCP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 22 Jun 2015 08:02:15 -0400
X-AuditID: cbfec7f5-f794b6d000001495-14-5587f9446d67
Message-id: <5587F943.3040006@samsung.com>
Date: Mon, 22 Jun 2015 15:02:11 +0300
From: Andrey Ryabinin <a.ryabinin@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.7.0
MIME-version: 1.0
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] vfs part 2
References: <20150415181406.GL889@ZenIV.linux.org.uk>
 <5538C66F.4050404@samsung.com> <20150621211213.GA18732@ZenIV.linux.org.uk>
In-reply-to: <20150621211213.GA18732@ZenIV.linux.org.uk>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrILMWRmVeSWpSXmKPExsVy+t/xK7ouP9tDDVbsVLDYs/cki8XlXXPY
	LB71vWW3OP/3OKsDi8eJGb9ZPD5vkvPY9OQtUwBzFJdNSmpOZllqkb5dAldGz3G3gr2cFS+O
	rmRpYNzL3sXIySEhYCKxfPMMVghbTOLCvfVsXYxcHEICSxklFp5rhXK+M0rc+d/GBlLFK6Al
	0b59BxOIzSKgKrHiQjcLiM0moCfxb9Z2sBpRgQiJt5dPMkHUC0r8mHwPrEYEqP7OqTNgcWaB
	QomPq9vAbGEBJYmnC+ZBLWtilFh75QfYeZwCFhLnDrYwdzFyADXoSdy/qAXRKy+xec1b5gmM
	ArOQrJiFUDULSdUCRuZVjKKppckFxUnpuUZ6xYm5xaV56XrJ+bmbGCEB+3UH49JjVocYBTgY
	lXh4Z9i3hwqxJpYVV+YeYpTgYFYS4W05CxTiTUmsrEotyo8vKs1JLT7EKM3BoiTOO3PX+xAh
	gfTEktTs1NSC1CKYLBMHp1QDY8p9jZeJgkFxV5+sW9cZYn7dsLLpYEfQ06kbZCQ8X9dLm5er
	Mto5e5zee2Vy7t3I13nut99N3CE/y4jj3Z6TfJcSQ5d6iZ6+dPLpkyR34xn3v/KmHNPudtZq
	XHj0C0fK/UOOH0u3qb+qv3h5r3q1Im920o03Vy22BEtO8HrMV38pROXlVDWZfiWW4oxEQy3m
	ouJEAFl6YG1UAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1308
Lines: 35

On 06/22/2015 12:12 AM, Al Viro wrote:
> On Thu, Apr 23, 2015 at 01:16:15PM +0300, Andrey Ryabinin wrote:
>> This change caused following:
> 
>> This could happen when p9pdu_readf() changes 'count' to some value > iov_iter_count(from):
>>
>> p9_client_write():
>> <...>
>> 		int count = iov_iter_count(from);
>> <...>
>> 		*err = p9pdu_readf(req->rc, clnt->proto_version, "d", &count);
>> <...>
>> 		iov_iter_advance(from, count);
> 
> *blink*
> 
> That's a bug, all right, but I would love to see how you trigger it.
> It would require server to respond to "write that many bytes" with "OK,
> <greater number> bytes written".  We certainly need to cope with that
> (we can't trust the server to be sane), but if that's what is going on,
> you've got a server bug as well.
> 
> Could you check if the patch below triggers WARN_ON() in it on your
> reproducer?  p9_client_read() has a similar issue as well...
> 

I've tried something like your patch before to check the read side
and I haven't seen anything before and don't see it right now.
Though, this doesn't mean that there is no problem with read.
I mean that trinity hits this on write and may just not hit this on read.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/