Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933199AbbFVMSN (ORCPT ); Mon, 22 Jun 2015 08:18:13 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:35139 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754364AbbFVMSG (ORCPT ); Mon, 22 Jun 2015 08:18:06 -0400 MIME-Version: 1.0 In-Reply-To: References: <1434102153-38581-1-git-send-email-Sreekanth.Reddy@avagotech.com> <1434102153-38581-10-git-send-email-Sreekanth.Reddy@avagotech.com> Date: Mon, 22 Jun 2015 17:48:04 +0530 Message-ID: Subject: Re: [PATCH 09/20] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files From: Sreekanth Reddy To: "Martin K. Petersen" Cc: "jejb@kernel.org" , Christoph Hellwig , "linux-scsi@vger.kernel.org" , "James E.J. Bottomley" , Sathya Prakash , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1441 Lines: 46 On Sat, Jun 20, 2015 at 1:57 AM, Martin K. Petersen wrote: >>>>>> Sreekanth Reddy writes: > >> @@ -1334,9 +1336,17 @@ typedef struct _MPI2_CONFIG_PAGE_BIOS_1 { >> *PTR_MPI2_CONFIG_PAGE_BIOS_1, >> Mpi2BiosPage1_t, *pMpi2BiosPage1_t; >> >> -#define MPI2_BIOSPAGE1_PAGEVERSION (0x05) >> +#define MPI2_BIOSPAGE1_PAGEVERSION (0x06) >> >> /*values for BIOS Page 1 BiosOptions field */ >> +#define MPI2_BIOSPAGE1_OPTIONS_X86_DISABLE_BIOS (0x00000400) > > Looks like you may have some bad whitespace here ^^^. Accepted. will post next version of this patch by removing these extra white spaces. Thanks, Sreekanth > >> + >> +#define MPI2_BIOSPAGE1_OPTIONS_MASK_REGISTRATION_UEFI_BSD (0x00000300) >> +#define MPI2_BIOSPAGE1_OPTIONS_USE_BIT0_REGISTRATION_UEFI_BSD (0x00000000) >> +#define MPI2_BIOSPAGE1_OPTIONS_FULL_REGISTRATION_UEFI_BSD (0x00000100) >> +#define MPI2_BIOSPAGE1_OPTIONS_ADAPTER_REGISTRATION_UEFI_BSD (0x00000200) >> +#define MPI2_BIOSPAGE1_OPTIONS_DISABLE_REGISTRATION_UEFI_BSD (0x00000300) > > Otherwise OK. > > Reviewed-by: Martin K. Petersen > > -- > Martin K. Petersen Oracle Linux Engineering -- Regards, Sreekanth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/