Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751618AbbFVOig (ORCPT ); Mon, 22 Jun 2015 10:38:36 -0400 Received: from mail.kernel.org ([198.145.29.136]:40490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbbFVOi2 (ORCPT ); Mon, 22 Jun 2015 10:38:28 -0400 Date: Mon, 22 Jun 2015 11:38:24 -0300 From: Arnaldo Carvalho de Melo To: Martin =?utf-8?B?TGnFoWth?= Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Paul Mackerras , Andi Kleen Subject: Re: [PATCH] perf annotate: With --show-total-period, display total # of samples. Message-ID: <20150622143824.GB13937@kernel.org> References: <5582ED6D.4010707@suse.cz> <20150618162627.GB6989@gmail.com> <558308A1.6060408@suse.cz> <20150618191534.GE3079@kernel.org> <5583E26D.1040407@suse.cz> <20150619191038.GD31188@kernel.org> <5585544B.3010405@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5585544B.3010405@suse.cz> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1615 Lines: 41 Em Sat, Jun 20, 2015 at 01:53:47PM +0200, Martin Liška escreveu: > On 06/19/2015 09:10 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Jun 19, 2015 at 11:35:41AM +0200, Martin Liška escreveu: > >> Thank you for the review, all remarks were reasonable. > >> Feel free to comment next version (v3) of the patch. > > Thanks, there was just one missing s/tuples/samples/g, I did it and > > tried running git-am on the attached patch, it failed, so I applied it > > manually. > Thank you for help, as I followed the documentation related to Thunderbird, > all spaces and tabs should gone. I still suspect that's culprit of the failure? Sometimes it is tricky to figure out exactly what went wrong, so I rather applied it by hand and just dropped a note, but my workflow, when submitting patches is: $ git format-patch -n --cover-letter tip/perf/core.. # edit 0000-cover-letter.txt $ smi 0* Where smi is: $ cat ~/bin/smi git send-email --from "Arnaldo Carvalho de Melo " \ --to "Ingo Molnar " \ --cc linux-kernel@vger.kernel.org --no-chain-reply-to $* $ Which I guess is what most contributors do, at least the ones I manage to use 'git am' on their patches, etc. I.e. no MUA involved, but of course a MUA can be used, just make sure that you can use git am on the message you first send to yourself, i.e. that you try replicating the upstream workflow when trying to apply your patches :-) - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/