Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbbFVQAi (ORCPT ); Mon, 22 Jun 2015 12:00:38 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:34230 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752597AbbFVQAd (ORCPT ); Mon, 22 Jun 2015 12:00:33 -0400 Message-ID: <5588311B.6030806@linaro.org> Date: Mon, 22 Jun 2015 17:00:27 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Archit Taneja , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org CC: robdclark@gmail.com, hali@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] drm/msm: dsi host: add missing of_node_put() References: <1434984861-22948-1-git-send-email-architt@codeaurora.org> <1434984861-22948-2-git-send-email-architt@codeaurora.org> In-Reply-To: <1434984861-22948-2-git-send-email-architt@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1092 Lines: 35 On 22/06/15 15:54, Archit Taneja wrote: > Decrement device node refcount if of_get_child_by_name is successfully > called. > > Signed-off-by: Archit Taneja > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > index de04009..1751659 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -1582,6 +1582,8 @@ int msm_dsi_host_register(struct mipi_dsi_host *host, bool check_defer) > node = of_get_child_by_name(msm_host->pdev->dev.of_node, > "panel"); > if (node) { > + of_node_put(node); > + Atleast from the current state of code, It looks like the driver is going to refer to the node of_node_put?, So I think this is not the right place to have of_node_put. > if (!of_drm_find_panel(node)) > return -EPROBE_DEFER; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/