Message-id: <558832A3.9060309@samsung.com>
Date: Mon, 22 Jun 2015 19:06:59 +0300
From: Andrey Ryabinin <a.ryabinin@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.7.0
MIME-version: 1.0
To: Ingo Molnar <mingo@kernel.org>, Dmitry Vyukov <dvyukov@google.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "x86@kernel.org" <x86@kernel.org>,
        Andrey Konovalov <adech.fo@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>,
        Alexander Popov <alpopov@ptsecurity.com>,
        Alexander Potapenko <glider@google.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] x86_64: kasan: add message about kasan being
 initialized
References: <1434734247-29153-1-git-send-email-a.ryabinin@samsung.com>
 <1434734247-29153-3-git-send-email-a.ryabinin@samsung.com>
 <CACT4Y+ZRJk+6QHGhN3Vz=Hnv=PjB2P-P-Y9UiZAHNsvO=7v_MA@mail.gmail.com>
 <20150620131813.GA6534@gmail.com>
In-reply-to: <20150620131813.GA6534@gmail.com>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 940
Lines: 23

On 06/20/2015 04:18 PM, Ingo Molnar wrote:
> 
> Please call it 'kasan' or 'KASAN', and also explain it in the message and prefix 
> it properly with the subsystem name (kasan), so something like:
> 
> 	pr_info("kasan: Kernel Address SANitizer (KASAN) initialized\n");
> 
> Other kasan messages should also carry a 'kasan: ' prefix, so that it's 
> unambiguous what generated the message, and also to make it easier to grep out of 
> logs.
> 

This patch adds "kasan: " prefix for all messages from this file ( +#define pr_fmt(fmt) "kasan: " fmt )

I'm agree with Dmitry, I would choose kasan name too.
In this case, adding explanation in the message will produce too much kasans in one short message:

	kasan: Kernel address sanitizer (kasan) initialized

Perhaps it would be better to keep this patch as is. Ok?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/