Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754104AbbFVQ7r (ORCPT ); Mon, 22 Jun 2015 12:59:47 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:60451 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751436AbbFVQ7k (ORCPT ); Mon, 22 Jun 2015 12:59:40 -0400 Date: Mon, 22 Jun 2015 09:59:38 -0700 From: Guenter Roeck To: Vivien Didelot Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck , linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [v2,3/3] watchdog: max63xx: add heartbeat to platform data Message-ID: <20150622165938.GA1526@roeck-us.net> References: <1434581940-15086-3-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434581940-15086-3-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1038 Lines: 26 Hi Vivien, On Wed, Jun 17, 2015 at 06:59:00PM -0400, Vivien Didelot wrote: > Actually, there is no way but the module parameter to set the desired > heartbeat. This patch allows a platform code to set it in the device > platform data. This is convenient for platforms and built-in drivers. > > To do so, initialize heartbeat to zero to allow the module parameter to > take precedence over the platform setting. If not set, it will still > default to DEFAULT_HEARTBEAT. > I think that warrants a bit of discussion. Is the chip used on an x86 system (no devicetree), and is there reason to believe that the default watchdog timeout is not good enough until the watchdog application starts and can configure it to a different value ? This is also a bit more complicated since gpio pin 0 can be a valid gpio pin number, so you'd have to explicitly state "don't use gpio" in the platform data. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/