Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752432AbbFVRau (ORCPT ); Mon, 22 Jun 2015 13:30:50 -0400 Received: from mail-yh0-f41.google.com ([209.85.213.41]:34471 "EHLO mail-yh0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751493AbbFVRan (ORCPT ); Mon, 22 Jun 2015 13:30:43 -0400 Date: Mon, 22 Jun 2015 13:30:39 -0400 From: Tejun Heo To: Jarkko Sakkinen Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, jgunthorpe@obsidianresearch.com, Vivien Didelot , Guenter Roeck , NeilBrown Subject: Re: [PATCH v7 1/3] sysfs: added sysfs_link_entry_to_kobj() Message-ID: <20150622173039.GA3710@mtj.duckdns.org> References: <1434993894-5911-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1434993894-5911-2-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434993894-5911-2-git-send-email-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 809 Lines: 20 On Mon, Jun 22, 2015 at 08:24:50PM +0300, Jarkko Sakkinen wrote: > Added a new function sysfs_link_group_to_kobj() that adds a symlink > from attribute or group to a kobject. Exported kernfs_remove_by_name_ns > in order to provide a way to remove such symlinks. > > Signed-off-by: Jarkko Sakkinen Hmmm... is this *really* necessary? If linking from the parent kobj doesn't make a fundamental functional difference, I don't think this is a good idea. If linking to the parent doesn't work, why doesn't it? Shouldn't that already be a different kobj then? I'd really like to keep groups as a dumb container of simple attrs. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/