Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932104AbbFVRrV (ORCPT ); Mon, 22 Jun 2015 13:47:21 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:45669 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753406AbbFVRqw (ORCPT ); Mon, 22 Jun 2015 13:46:52 -0400 Date: Mon, 22 Jun 2015 20:46:02 +0300 From: Dan Carpenter To: Juston Li Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: use tabs for indentation Message-ID: <20150622174601.GF28762@mwanda> References: <1434761450-15722-1-git-send-email-juston.h.li@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434761450-15722-1-git-send-email-juston.h.li@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 667 Lines: 21 On Fri, Jun 19, 2015 at 05:50:50PM -0700, Juston Li wrote: > void sii164ClearInterrupt(void) > { > - unsigned char detectReg; > + unsigned char detectReg; > > - /* Clear the MDI interrupt */ > - detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT); > - i2cWriteReg(SII164_I2C_ADDRESS, SII164_DETECT, detectReg | SII164_DETECT_MONITOR_STATE_CLEAR); The patch accidentally deletes this write. > + /* Clear the MDI interrupt */ > + detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT); > } regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/