Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753555AbbFVRt0 (ORCPT ); Mon, 22 Jun 2015 13:49:26 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:33508 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477AbbFVRtT (ORCPT ); Mon, 22 Jun 2015 13:49:19 -0400 Message-ID: <55884A9B.9030505@cogentembedded.com> Date: Mon, 22 Jun 2015 20:49:15 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Phil Edworthy , Kishon Vijay Abraham I , Yoshihiro Shimoda , Simon Horman CC: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH 3/3] arm: koelsch: make USB0 perform Host/Function switching References: <1434984151-27274-1-git-send-email-phil.edworthy@renesas.com> <1434984151-27274-4-git-send-email-phil.edworthy@renesas.com> <55884943.9080607@cogentembedded.com> In-Reply-To: <55884943.9080607@cogentembedded.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1414 Lines: 45 Hello. On 06/22/2015 08:43 PM, Sergei Shtylyov wrote: >> Both USB Host (pci0) and Function (USBHS) drivers are enabled. >> The USB PHY driver determines which IP block should be connected >> based on vbus and id signals read via gpios. >> Signed-off-by: Phil Edworthy >> --- >> arch/arm/boot/dts/r8a7791-koelsch.dts | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts >> b/arch/arm/boot/dts/r8a7791-koelsch.dts >> index cffe33f..8f394be 100644 >> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts >> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > [...] >> @@ -627,13 +626,15 @@ >> >> &hsusb { >> status = "okay"; >> - pinctrl-0 = <&usb0_pins>; >> pinctrl-names = "default"; >> - renesas,enable-gpio = <&gpio5 31 GPIO_ACTIVE_HIGH>; >> }; >> >> &usbphy { >> status = "okay"; >> + renesas,pwr = <&gpio2 4 GPIO_ACTIVE_HIGH>; >> + renesas,id = <&gpio5 31 GPIO_ACTIVE_HIGH>; >> + renesas,vbus = <&gpio7 24 GPIO_ACTIVE_HIGH>; >> + renesas,vbus-pwr = <&gpio7 23 GPIO_ACTIVE_HIGH>; > The prop names should end with "-gpio" or even "-gpios", according to the > GPIO bindings. Oh, and you didn't document the props in the previous patch. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/