Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932192AbbFVRxR (ORCPT ); Mon, 22 Jun 2015 13:53:17 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:36184 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752757AbbFVRxE (ORCPT ); Mon, 22 Jun 2015 13:53:04 -0400 Date: Mon, 22 Jun 2015 11:52:53 -0600 From: Jason Gunthorpe To: Tejun Heo Cc: Jarkko Sakkinen , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, Vivien Didelot , Guenter Roeck , NeilBrown Subject: Re: [PATCH v7 1/3] sysfs: added sysfs_link_entry_to_kobj() Message-ID: <20150622175253.GA28080@obsidianresearch.com> References: <1434993894-5911-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1434993894-5911-2-git-send-email-jarkko.sakkinen@linux.intel.com> <20150622173039.GA3710@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150622173039.GA3710@mtj.duckdns.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.192 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 24 On Mon, Jun 22, 2015 at 01:30:39PM -0400, Tejun Heo wrote: > On Mon, Jun 22, 2015 at 08:24:50PM +0300, Jarkko Sakkinen wrote: > > Added a new function sysfs_link_group_to_kobj() that adds a symlink > > from attribute or group to a kobject. Exported kernfs_remove_by_name_ns > > in order to provide a way to remove such symlinks. > > > > Signed-off-by: Jarkko Sakkinen > > Hmmm... is this *really* necessary? If linking from the parent kobj > doesn't make a fundamental functional difference, I don't think this > is a good idea. If linking to the parent doesn't work, why doesn't > it? Shouldn't that already be a different kobj then? I'd really like > to keep groups as a dumb container of simple attrs. TPM is undergoing a migration of core attributes from the platform_device to the core's struct device. The only purpose of the symlink was to provide userspace compatability with the old location. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/