Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753271AbbFVSB7 (ORCPT ); Mon, 22 Jun 2015 14:01:59 -0400 Received: from mail-yk0-f175.google.com ([209.85.160.175]:34071 "EHLO mail-yk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbbFVSB6 (ORCPT ); Mon, 22 Jun 2015 14:01:58 -0400 Date: Mon, 22 Jun 2015 14:01:54 -0400 From: Tejun Heo To: Jason Gunthorpe Cc: Jarkko Sakkinen , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, Vivien Didelot , Guenter Roeck , NeilBrown Subject: Re: [PATCH v7 1/3] sysfs: added sysfs_link_entry_to_kobj() Message-ID: <20150622180154.GC3710@mtj.duckdns.org> References: <1434993894-5911-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1434993894-5911-2-git-send-email-jarkko.sakkinen@linux.intel.com> <20150622173039.GA3710@mtj.duckdns.org> <20150622175253.GA28080@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150622175253.GA28080@obsidianresearch.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1329 Lines: 31 On Mon, Jun 22, 2015 at 11:52:53AM -0600, Jason Gunthorpe wrote: > On Mon, Jun 22, 2015 at 01:30:39PM -0400, Tejun Heo wrote: > > On Mon, Jun 22, 2015 at 08:24:50PM +0300, Jarkko Sakkinen wrote: > > > Added a new function sysfs_link_group_to_kobj() that adds a symlink > > > from attribute or group to a kobject. Exported kernfs_remove_by_name_ns > > > in order to provide a way to remove such symlinks. > > > > > > Signed-off-by: Jarkko Sakkinen > > > > Hmmm... is this *really* necessary? If linking from the parent kobj > > doesn't make a fundamental functional difference, I don't think this > > is a good idea. If linking to the parent doesn't work, why doesn't > > it? Shouldn't that already be a different kobj then? I'd really like > > to keep groups as a dumb container of simple attrs. > > TPM is undergoing a migration of core attributes from the > platform_device to the core's struct device. > > The only purpose of the symlink was to provide userspace > compatability with the old location. Ah, yeah, that's painful. Can you please briefly explain why it wasn't necessary before? Are you merging multiple devices into one? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/