Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752473AbbFVSai (ORCPT ); Mon, 22 Jun 2015 14:30:38 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:36255 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751421AbbFVSab (ORCPT ); Mon, 22 Jun 2015 14:30:31 -0400 MIME-Version: 1.0 In-Reply-To: <20150622174601.GF28762@mwanda> References: <1434761450-15722-1-git-send-email-juston.h.li@gmail.com> <20150622174601.GF28762@mwanda> Date: Mon, 22 Jun 2015 11:30:30 -0700 X-Google-Sender-Auth: EGDSEnz0Gb6VxMcuxbepZA4N5_w Message-ID: Subject: Re: [PATCH] staging: sm750fb: use tabs for indentation From: Juston Li To: Dan Carpenter Cc: Sudip Mukherjee , teddy.wang@siliconmotion.com, Greg KH , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 29 On Mon, Jun 22, 2015 at 10:46 AM, Dan Carpenter wrote: > On Fri, Jun 19, 2015 at 05:50:50PM -0700, Juston Li wrote: >> void sii164ClearInterrupt(void) >> { >> - unsigned char detectReg; >> + unsigned char detectReg; >> >> - /* Clear the MDI interrupt */ >> - detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT); >> - i2cWriteReg(SII164_I2C_ADDRESS, SII164_DETECT, detectReg | SII164_DETECT_MONITOR_STATE_CLEAR); > > The patch accidentally deletes this write. > >> + /* Clear the MDI interrupt */ >> + detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT); >> } > > regards, > dan carpenter This was fixed and patch is now included in the patchset: [PATCH v2 00/19] staging: sm750fb: checkpatch.pl fixes Regards Juston -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/