Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753578AbbFVXDm (ORCPT ); Mon, 22 Jun 2015 19:03:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36679 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbbFVXDd (ORCPT ); Mon, 22 Jun 2015 19:03:33 -0400 Date: Tue, 23 Jun 2015 01:02:18 +0200 From: Oleg Nesterov To: Peter Zijlstra Cc: paulmck@linux.vnet.ibm.com, tj@kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org, der.herr@hofr.at, dave@stgolabs.net, riel@redhat.com, viro@ZenIV.linux.org.uk, torvalds@linux-foundation.org Subject: Re: [RFC][PATCH 05/13] percpu-rwsem: Optimize readers and reduce global impact Message-ID: <20150622230218.GB5582@redhat.com> References: <20150622121623.291363374@infradead.org> <20150622122256.064223889@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150622122256.064223889@infradead.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 387 Lines: 12 On 06/22, Peter Zijlstra wrote: > > +enum { readers_slow, readers_block }; I still think this enum doesn't make sense, and percpu_rw_semaphore->state should be a boolean. But this is really minor and subjective. Reviewed-by: Oleg Nesterov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/