Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753226AbbFWB1Q (ORCPT ); Mon, 22 Jun 2015 21:27:16 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:36466 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbbFWB1I (ORCPT ); Mon, 22 Jun 2015 21:27:08 -0400 MIME-Version: 1.0 In-Reply-To: <20150623004744.GA11212@redhat.com> References: <20150621210725.GA18220@redhat.com> <20150621211951.GA18593@redhat.com> <20150623004744.GA11212@redhat.com> From: Andy Lutomirski Date: Mon, 22 Jun 2015 18:26:46 -0700 Message-ID: Subject: Re: vdso && f_op->mremap (Was: special_mapping_fault() is broken) To: Oleg Nesterov Cc: Andrew Morton , Al Viro , Benjamin LaHaise , Hugh Dickins , Jeff Moyer , Kirill Shutemov , Linus Torvalds , "linux-kernel@vger.kernel.org" , Andy Lutomirski , Pavel Emelyanov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 997 Lines: 26 On Mon, Jun 22, 2015 at 5:47 PM, Oleg Nesterov wrote: > On 06/21, Oleg Nesterov wrote: >> >> Forgot to add Andy... > > Add Pavel ;) > > I never understood why ->mremap() lives in file_operations, not in > vm_operations_struct. To me vma->vm_file->f_op in move_vma() just > looks strange, vma->vm_ops->mremap(new_vma) looks "obviously better". > > And afaics more useful. CRIU remaps vdso, but this does not update > mm->context.vdso. OK, probably this does not matter currently, CRIU > can't c/r the compat tasks, and 64-bit apps do not use context.vdso. > Afaics. Still, I think we might want to have special_mapping_remap() > and we can't do this because ->vm_file == NULL. I would like this. Then I could clean up and resubmit my patch to keep context.vdso up to date. Oleg, can you let me know what patch, if any, I should be reviewing? --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/