Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751429AbbFWFCP (ORCPT ); Tue, 23 Jun 2015 01:02:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43836 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbbFWFCI (ORCPT ); Tue, 23 Jun 2015 01:02:08 -0400 Message-ID: <5588E84A.2000509@codeaurora.org> Date: Tue, 23 Jun 2015 10:32:02 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Srinivas Kandagatla , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org CC: robdclark@gmail.com, hali@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] drm/msm: dsi host: add missing of_node_put() References: <1434984861-22948-1-git-send-email-architt@codeaurora.org> <1434984861-22948-2-git-send-email-architt@codeaurora.org> <5588311B.6030806@linaro.org> In-Reply-To: <5588311B.6030806@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1354 Lines: 42 On 06/22/2015 09:30 PM, Srinivas Kandagatla wrote: > > > On 22/06/15 15:54, Archit Taneja wrote: >> Decrement device node refcount if of_get_child_by_name is successfully >> called. >> >> Signed-off-by: Archit Taneja >> --- >> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c >> b/drivers/gpu/drm/msm/dsi/dsi_host.c >> index de04009..1751659 100644 >> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c >> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c >> @@ -1582,6 +1582,8 @@ int msm_dsi_host_register(struct mipi_dsi_host >> *host, bool check_defer) >> node = of_get_child_by_name(msm_host->pdev->dev.of_node, >> "panel"); >> if (node) { >> + of_node_put(node); >> + > > Atleast from the current state of code, It looks like the driver is > going to refer to the node of_node_put?, So I think this is not the > right place to have of_node_put. That's right. I made the same mistake in the later patches too. I'll fix these. Thanks, Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/