Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752760AbbFWGYO (ORCPT ); Tue, 23 Jun 2015 02:24:14 -0400 Received: from mail.emea.novell.com ([130.57.118.101]:57725 "EHLO mail.emea.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969AbbFWGYD convert rfc822-to-8bit (ORCPT ); Tue, 23 Jun 2015 02:24:03 -0400 Message-Id: <5589179F0200007800087E6E@mail.emea.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.0.1 Date: Tue, 23 Jun 2015 07:23:59 +0100 From: "Jan Beulich" To: "Konrad Rzeszutek Wilk" Cc: , , , , , , , , Subject: Re: [Xen-devel] [PATCH] drivers: xen-blkfront: only talk_to_blkback() when in XenbusStateInitialising References: <558762C4.2000002@oracle.com> <1434981360-29794-1-git-send-email-konrad.wilk@oracle.com> In-Reply-To: <1434981360-29794-1-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 658 Lines: 19 >>> On 22.06.15 at 15:56, wrote: > --- a/drivers/block/xen-blkfront.c > +++ b/drivers/block/xen-blkfront.c > @@ -1951,6 +1951,8 @@ static void blkback_changed(struct xenbus_device *dev, > > switch (backend_state) { > case XenbusStateInitWait: > + if (dev->state != XenbusStateInitialising) > + break; If, as you say in a subsequent reply, all other drivers already have such a check, wouldn't it make more sense to put this into xenbus' backend_changed() or even xenbus_otherend_changed()? Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/