Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753509AbbFWHTo (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Jun 2015 03:19:44 -0400
Received: from mail-wi0-f171.google.com ([209.85.212.171]:35125 "EHLO
	mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753840AbbFWHT0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Jun 2015 03:19:26 -0400
Date: Tue, 23 Jun 2015 08:19:21 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Varka Bhadram <varkabhadram@gmail.com>,
        Shobhit Kumar <shobhit.kumar@intel.com>,
        linux-pwm <linux-pwm@vger.kernel.org>,
        intel-gfx <intel-gfx@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        Alexandre Courbot <gnurou@gmail.com>, Paul Bolle <pebolle@tiscali.nl>,
        Samuel Ortiz <sameo@linux.intel.com>,
        Povilas Staniulis <wdmonster@gmail.com>,
        Jani Nikula <jani.nikula@intel.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Paul Gortmaker <paul.gortmaker@windriver.com>, bloften80@gmail.com,
        David Airlie <airlied@linux.ie>,
        Chih-Wei Huang <cwhuang@android-x86.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [Intel-gfx] [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup
 table for CRC PMIC based PWM
Message-ID: <20150623071921.GE3245@x1>
References: <1434970465-12687-1-git-send-email-shobhit.kumar@intel.com>
 <1434970465-12687-5-git-send-email-shobhit.kumar@intel.com>
 <5587EB7A.5090402@gmail.com>
 <20150622141908.GM25769@phenom.ffwll.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20150622141908.GM25769@phenom.ffwll.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1715
Lines: 49

On Mon, 22 Jun 2015, Daniel Vetter wrote:

> On Mon, Jun 22, 2015 at 04:33:22PM +0530, Varka Bhadram wrote:
> > Hi Shobhit Kumar,
> > 
> > On 06/22/2015 04:24 PM, Shobhit Kumar wrote:
> > 
> > >On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup
> > >entry for the same to be used by the consumer (Intel GFX)
> > >
> > >v2: Remove the lookup table on driver unload (Thierry)
> > >
> > >v3: Correct the subject line (Lee jones)
> > 
> > This part should only describe what this is about..
> > 
> > Don't put this patch change history over here.
> > Include this change history after
> > ...
> > Signed-off-by: Author <email>
> > ---
> > 
> > >CC: Samuel Ortiz <sameo@linux.intel.com>
> > >Cc: Linus Walleij <linus.walleij@linaro.org>
> > >Cc: Alexandre Courbot <gnurou@gmail.com>
> > >Cc: Thierry Reding <thierry.reding@gmail.com>
> > >Acked-by: Lee Jones <lee.jones@linaro.org>
> > >Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
> > >---
> > 
> > Here you add this change history so that after applying this
> > will not be the part of your commit description.
> > 
> > This comment is applicable for all of your patches.
> 
> It's honestly a per-maintainer thing and hard to tell who wants what ...
> Personally I do want to include the patch changelog in the commit message.

The patch change-log should go below the '---'.  There are very few
(weird ;) ) Maintainers who like to see them in the commit log.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/