Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754405AbbFWIAt (ORCPT ); Tue, 23 Jun 2015 04:00:49 -0400 Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:49891 "EHLO lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752477AbbFWIAZ (ORCPT ); Tue, 23 Jun 2015 04:00:25 -0400 Message-ID: <1435046411.4528.6.camel@tiscali.nl> Subject: Re: [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms From: Paul Bolle To: Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: kernel@stlinux.com, rjw@rjwysocki.net, viresh.kumar@linaro.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, ajitpal.singh@st.com Date: Tue, 23 Jun 2015 10:00:11 +0200 In-Reply-To: <1434987837-24212-8-git-send-email-lee.jones@linaro.org> References: <1434987837-24212-1-git-send-email-lee.jones@linaro.org> <1434987837-24212-8-git-send-email-lee.jones@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3 (3.16.3-2.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1717 Lines: 54 On Mon, 2015-06-22 at 16:43 +0100, Lee Jones wrote: > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > +config ARM_ST_CPUFREQ > +> > bool "ST CPUFreq support" > +> > depends on SOC_STIH407 > +> > help > +> > OPP list for cpufreq-dt driver can be provided through DT or can be > +> > created at runtime. Select this if you want create OPP list at runtime. > --- a/drivers/cpufreq/Makefile > +++ b/drivers/cpufreq/Makefile > +obj-$(CONFIG_ARM_ST_CPUFREQ) += st-cpufreq.o > --- /dev/null > +++ b/drivers/cpufreq/st-cpufreq.c > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > +#include > +MODULE_DEVICE_TABLE(of, sti_cpufreq_of_match); > > +module_platform_driver(sti_cpufreq); > > +MODULE_AUTHOR("Ajitpal Singh "); > +MODULE_DESCRIPTION("Creates an OPP list for cpufreq-cpu0 at runtime"); > +MODULE_LICENSE("GPL v2"); (There's a mismatch between the license used in the comment at the top of this file and the ident used in the MODULE_LICENSE() macro. See include/linux/module.h.) st-cpufreq.o can only be built-in. But the code contains of few lines that are only useful if the code can be modular. Was ARM_ST_CPUFREQ perhaps meant to be tristate? Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/