Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754063AbbFWIxE (ORCPT ); Tue, 23 Jun 2015 04:53:04 -0400 Received: from mail-yk0-f175.google.com ([209.85.160.175]:33712 "EHLO mail-yk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752185AbbFWIwy (ORCPT ); Tue, 23 Jun 2015 04:52:54 -0400 MIME-Version: 1.0 X-Originating-IP: [37.11.0.18] In-Reply-To: <20150623083856.GH3245@x1> References: <1434987837-24212-1-git-send-email-lee.jones@linaro.org> <1434987837-24212-9-git-send-email-lee.jones@linaro.org> <20150623023458.GC16776@linux> <20150623070651.GA3245@x1> <20150623075509.GF16776@linux> <20150623083856.GH3245@x1> Date: Tue, 23 Jun 2015 10:52:53 +0200 Message-ID: Subject: Re: [PATCH 8/8] dt: cpufreq: st: Provide bindings for ST's CPUFreq implementation From: Javier Martinez Canillas To: Lee Jones Cc: Viresh Kumar , Rob Herring , kernel@stlinux.com, "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Linux Kernel , "devicetree@vger.kernel.org" , ajitpal.singh@st.com, "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 50 Hello Lee and Viresh, On Tue, Jun 23, 2015 at 10:38 AM, Lee Jones wrote: > On Tue, 23 Jun 2015, Viresh Kumar wrote: >> On 23-06-15, 08:06, Lee Jones wrote: >> > >> > > Over that, this patch should have been present before any other >> > > patches using these bindings. >> > >> > I've never heard that one before, but it's easy to re-order the set. >> >> I don't know, but it seems obvious to me: Bindings first and then the >> code. > > Do you always write your documentation before implementing a > feature? > > Surely it goes; > Requirements Gathering > Plan and Prepare > Implement > Test > Document > Deliver > > ;) > > ... but as I say, I can re-order if required. It's really not a problem. > This is actually documented in Documentation/devicetree/bindings/submitting-patches.txt: ... 3) The Documentation/ portion of the patch should come in the series before the code implementing the binding. .... The rationale AFAIU is that it is easier to review the implementation of a binding after reading the DT binding doc since then you can see if the code matches what the DT binding describes. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/