Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932596AbbFWJ0s (ORCPT ); Tue, 23 Jun 2015 05:26:48 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:34598 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932456AbbFWJ0c convert rfc822-to-8bit (ORCPT ); Tue, 23 Jun 2015 05:26:32 -0400 Subject: Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: text/plain; charset=windows-1252 From: Pantelis Antoniou In-Reply-To: <1435035173.9808.35.camel@perches.com> Date: Tue, 23 Jun 2015 10:26:28 +0100 Cc: Srinivas Kandagatla , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Maxime Ripard , Rob Herring , Kumar Gala , Mark Brown , s.hauer@pengutronix.de, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Arnd Bergmann , sboyd@codeaurora.org, Matt Porter , stefan.wahren@i2se.com, wxt@rock-chips.com Content-Transfer-Encoding: 8BIT Message-Id: <7BE8C921-180A-411D-A3C0-5D2A7AE3AB6A@konsulko.com> References: <1435014459-26138-1-git-send-email-srinivas.kandagatla@linaro.org> <1435014507-26181-1-git-send-email-srinivas.kandagatla@linaro.org> <1435035173.9808.35.camel@perches.com> To: Joe Perches X-Mailer: Apple Mail (2.2098) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1183 Lines: 37 Hi Joe, > On Jun 23, 2015, at 05:52 , Joe Perches wrote: > > On Tue, 2015-06-23 at 00:08 +0100, Srinivas Kandagatla wrote: >> This patch adds just providers part of the framework just to enable easy >> review. > [] >> include/linux/nvmem-provider.h | 54 ++++++ > > Unless there are going to be users of nvmem-provider.h > outside of the drivers/nvmem directory, perhaps that > file (and nvmem-consumer.h) should be in drivers/nvmem/ > > nvmem-consumer.h should be accessible from any driver, no? And unfortunately nvmem-provider should be accessible too. There are already eeprom drivers in the eeprom/misc directory that cannot be moved yet to drivers/nvmem (like at24). They need the provider definitions while they provide both the old style interface, and the new NVMEM based one. When we move them to the drivers/nvmem directory, then yes the provider header file should move there. Regards ? Pantelis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/