Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932368AbbFWJWH (ORCPT ); Tue, 23 Jun 2015 05:22:07 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:60345 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752185AbbFWJWD (ORCPT ); Tue, 23 Jun 2015 05:22:03 -0400 Date: Tue, 23 Jun 2015 02:33:51 -0700 (PDT) Message-Id: <20150623.023351.212943884120317727.davem@davemloft.net> To: stsp@list.ru Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, netdev@vger.kernel.org, f.fainelli@gmail.com, thomas.petazzoni@free-electrons.com, arno@natisbad.org, stsp@users.sourceforge.net Subject: Re: [PATCH] mvneta: add forgotten initialization of autonegotiation bits From: David Miller In-Reply-To: <5582E563.3010801@list.ru> References: <5582E563.3010801@list.ru> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Jun 2015 02:22:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1341 Lines: 35 From: Stas Sergeev Date: Thu, 18 Jun 2015 18:36:03 +0300 > > The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link state > signaling") > changed mvneta_adjust_link() so that it does not clear the auto-negotiation > bits in MVNETA_GMAC_AUTONEG_CONFIG register. This was necessary for > auto-negotiation mode to work. > Unfortunately I haven't checked if these bits are ever initialized. > It appears they are not. > This patch adds the missing initialization of the auto-negotiation bits > in the MVNETA_GMAC_AUTONEG_CONFIG register. > It fixes the following regression: > https://www.mail-archive.com/netdev@vger.kernel.org/msg67928.html > > Since the patch was tested to fix a regression, it should be applied to > stable tree. > > Tested-by: Arnaud Ebalard > > CC: Thomas Petazzoni > CC: Florian Fainelli > CC: netdev@vger.kernel.org > CC: linux-kernel@vger.kernel.org > CC: stable@vger.kernel.org > > Signed-off-by: Stas Sergeev Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/