Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754523AbbFWKW4 (ORCPT ); Tue, 23 Jun 2015 06:22:56 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:60677 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbbFWKWr (ORCPT ); Tue, 23 Jun 2015 06:22:47 -0400 Date: Tue, 23 Jun 2015 03:34:36 -0700 (PDT) Message-Id: <20150623.033436.27435944821901354.davem@davemloft.net> To: imrep.amz@gmail.com Cc: xen-devel@lists.xenproject.org, ian.campbell@citrix.com, wei.liu2@citrix.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imrep@amazon.de, msw@amazon.com Subject: Re: [PATCH] xen-netback: fix a BUG() during initialization From: David Miller In-Reply-To: <1434716511-25657-1-git-send-email-imrep.amz@gmail.com> References: <1434716511-25657-1-git-send-email-imrep.amz@gmail.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Jun 2015 03:22:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1136 Lines: 27 From: Imre Palik Date: Fri, 19 Jun 2015 14:21:51 +0200 > From: "Palik, Imre" > > Commit edafc132baac ("xen-netback: making the bandwidth limiter runtime settable") > introduced the capability to change the bandwidth rate limit at runtime. > But it also introduced a possible crashing bug. > > If netback receives two XenbusStateConnected without getting the > hotplug-status watch firing in between, then it will try to register the > watches for the rate limiter again. But this triggers a BUG() in the watch > registration code. > > The fix modifies connect() to remove the possibly existing packet-rate > watches before trying to install those watches. This behaviour is in line > with how connect() deals with the hotplug-status watch. > > Signed-off-by: Imre Palik > Cc: Matt Wilson Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/