Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932687AbbFWMMv (ORCPT ); Tue, 23 Jun 2015 08:12:51 -0400 Received: from mail-qk0-f169.google.com ([209.85.220.169]:35145 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754617AbbFWMMn (ORCPT ); Tue, 23 Jun 2015 08:12:43 -0400 MIME-Version: 1.0 X-Originating-IP: [80.15.154.113] In-Reply-To: <1435061246-14690-1-git-send-email-sricharan@codeaurora.org> References: <1435061246-14690-1-git-send-email-sricharan@codeaurora.org> Date: Tue, 23 Jun 2015 14:12:42 +0200 Message-ID: Subject: Re: [PATCH] iommu/arm-smmu: Fix bug in ARM_SMMU_FEAT_TRANS_OPS condition check From: Baptiste Reynal To: Sricharan R Cc: "moderated list:ARM SMMU DRIVER" , Linux IOMMU , Will Deacon , linux-arm-msm@vger.kernel.org, open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1548 Lines: 38 This issue has already been fixed here : http://www.spinics.net/lists/arm-kernel/msg424824.html Regards, Baptiste On Tue, Jun 23, 2015 at 2:07 PM, Sricharan R wrote: > Patch 'fix ARM_SMMU_FEAT_TRANS_OPS condition' changed the check > for ARM_SMMU_FEAT_TRANS_OPS to be based on presence of stage1 check, > but used (id & ID0_ATOSNS) instead of !(id & ID0_ATOSNS). > Fix it here. > > Signed-off-by: Sricharan R > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 09091e9..fbf4af6 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1866,7 +1866,7 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu) > return -ENODEV; > } > > - if ((id & ID0_S1TS) && ((smmu->version == 1) || (id & ID0_ATOSNS))) { > + if ((id & ID0_S1TS) && ((smmu->version == 1) || !(id & ID0_ATOSNS))) { > smmu->features |= ARM_SMMU_FEAT_TRANS_OPS; > dev_notice(smmu->dev, "\taddress translation ops\n"); > } > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/