Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932456AbbFWMZu (ORCPT ); Tue, 23 Jun 2015 08:25:50 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:57239 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754557AbbFWMZm (ORCPT ); Tue, 23 Jun 2015 08:25:42 -0400 X-IronPort-AV: E=Sophos;i="5.13,665,1427752800"; d="scan'208";a="137492869" Date: Tue, 23 Jun 2015 14:25:38 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Daniel Granat cc: Julia.Lawall@lip6.fr, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, k.wrona@samsung.com, k.kozlowski@samsung.com Subject: Re: [PATCH v5] Added tables (i2c/platform)_device_id for checking. Extend checking on tables containing structures which are initialized without specifying member name. In-Reply-To: <1435057334-5751-1-git-send-email-d.granat@samsung.com> Message-ID: References: <1435057334-5751-1-git-send-email-d.granat@samsung.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2283 Lines: 99 On Tue, 23 Jun 2015, Daniel Granat wrote: > Signed-off-by: Daniel Granat Acked-by: Julia Lawall > --- > scripts/coccinelle/misc/of_table.cocci | 33 ++++++++++++++++++++++++++++----- > 1 file changed, 28 insertions(+), 5 deletions(-) > > diff --git a/scripts/coccinelle/misc/of_table.cocci b/scripts/coccinelle/misc/of_table.cocci > index 3c93404..2294915 100644 > --- a/scripts/coccinelle/misc/of_table.cocci > +++ b/scripts/coccinelle/misc/of_table.cocci > @@ -1,6 +1,6 @@ > -/// Make sure of_device_id tables are NULL terminated > +/// Make sure (of/i2c/platform)_device_id tables are NULL terminated > // > -// Keywords: of_table > +// Keywords: of_table i2c_table platform_table > // Confidence: Medium > // Options: --include-headers > > @@ -13,18 +13,26 @@ virtual report > identifier var, arr; > expression E; > @@ > -struct of_device_id arr[] = { > +( > +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = { > ..., > { > .var = E, > * } > }; > +| > +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = { > + ..., > +* { ..., E, ... }, > +}; > +) > > @depends on patch@ > identifier var, arr; > expression E; > @@ > -struct of_device_id arr[] = { > +( > +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = { > ..., > { > .var = E, > @@ -32,19 +40,34 @@ struct of_device_id arr[] = { > + }, > + { } > }; > +| > +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = { > + ..., > + { ..., E, ... }, > ++ { }, > +}; > +) > > @r depends on org || report@ > position p1; > identifier var, arr; > expression E; > @@ > -struct of_device_id arr[] = { > +( > +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = { > ..., > { > .var = E, > } > @p1 > }; > +| > +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = { > + ..., > + { ..., E, ... } > + @p1 > +}; > +) > > @script:python depends on org@ > p1 << r.p1; > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/