Date: Tue, 23 Jun 2015 15:05:30 +0200
From: Luis de Bethencourt <luis@debethencourt.com>
To: Frans Klaver <fransklaver@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Antoine Schweitzer-Chaput <antoine@schweitzer-chaput.fr>,
        Cristina Opriceana <cristina.opriceana@gmail.com>,
        Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
        Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
        Koray Gulcu <koray.gulcu@ozu.edu.tr>, Greg Donald <gdonald@gmail.com>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Ebru Akagunduz <ebru.akagunduz@gmail.com>,
        Karthik Nayak <karthik.188@gmail.com>, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: rtl8192u: bool tests don't need comparisons
Message-ID: <20150623130530.GA1655@goodgumbo.baconseed.org>
References: <20150623125224.GA991@goodgumbo.baconseed.org>
 <CAH6sp9PvyPCbxdCVt5-grfXA+Vk=vwhDpKDU1j3kzUNumZrLAw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAH6sp9PvyPCbxdCVt5-grfXA+Vk=vwhDpKDU1j3kzUNumZrLAw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1555
Lines: 41

On Tue, Jun 23, 2015 at 02:56:38PM +0200, Frans Klaver wrote:
> On Tue, Jun 23, 2015 at 2:52 PM, Luis de Bethencourt
> <luis@debethencourt.com> wrote:
> > Remove explicit true/false comparations to bool variables.
> >
> > Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> > ---
> >  drivers/staging/rtl8192u/r8192U_core.c |  7 ++++---
> >  drivers/staging/rtl8192u/r8192U_dm.c   | 21 +++++++++++----------
> >  2 files changed, 15 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> > index a4795af..c53d670 100644
> > --- a/drivers/staging/rtl8192u/r8192U_core.c
> > +++ b/drivers/staging/rtl8192u/r8192U_core.c
> > @@ -2047,7 +2047,7 @@ static bool GetHalfNmodeSupportByAPs819xUsb(struct net_device *dev)
> >         struct r8192_priv *priv = ieee80211_priv(dev);
> >         struct ieee80211_device *ieee = priv->ieee80211;
> >
> > -       if (ieee->bHalfWirelessN24GMode == true)
> > +       if (ieee->bHalfWirelessN24GMode)
> >                 Reval = true;
> >         else
> >                 Reval =  false;
> 
> With this one I'd go as far as saying that
> 
> Reval = ieee->bHalfWirelessN24GMode;
> 
> Frans

Completely missed that. Good catch.

Thanks for the review! Sending an updated version now.

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/