Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932896AbbFWNGq (ORCPT ); Tue, 23 Jun 2015 09:06:46 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:33348 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932500AbbFWNGg (ORCPT ); Tue, 23 Jun 2015 09:06:36 -0400 Date: Tue, 23 Jun 2015 06:18:25 -0700 (PDT) Message-Id: <20150623.061825.2036705332261161582.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, linux@roeck-us.net, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [PATCH] net: dsa: mv88e6xxx: split phy page accessors From: David Miller In-Reply-To: <1434724330-3442-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1434724330-3442-1-git-send-email-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Jun 2015 06:06:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 22 From: Vivien Didelot Date: Fri, 19 Jun 2015 10:32:10 -0400 > Split mv88e6xxx_phy_page_read and mv88e6xxx_phy_page_write into two > functions each, one to acquire the smi_mutex and one to call the actual > read/write functions. > > This will be useful to access registers such as Fiber/SERDES Control, > from setup code with SMI lock held. > > Also rename their "error" labels to "clear", since it is not only an > error path. > > Signed-off-by: Vivien Didelot Please resubmit this alongside a patch that actually uses the new facility. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/