Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754813AbbFWN1r (ORCPT ); Tue, 23 Jun 2015 09:27:47 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:33464 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752229AbbFWN1i (ORCPT ); Tue, 23 Jun 2015 09:27:38 -0400 Date: Tue, 23 Jun 2015 06:39:26 -0700 (PDT) Message-Id: <20150623.063926.723221732046739833.davem@davemloft.net> To: alex.popov@linux.com Cc: pantelis.antoniou@gmail.com, vbordug@ru.mvista.com, christophe.leroy@c-s.fr, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] net: fs_enet: Fix NETIF_F_SG feature for Freescale MPC5121 From: David Miller In-Reply-To: <1434839566-31704-1-git-send-email-alex.popov@linux.com> References: <1434839566-31704-1-git-send-email-alex.popov@linux.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Jun 2015 06:27:38 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1088 Lines: 28 From: Alexander Popov Date: Sun, 21 Jun 2015 01:32:46 +0300 > Commit 4fc9b87bae25 ("net: fs_enet: Implement NETIF_F_SG feature") > brings a trouble to Freescale MPC512x: a kernel oops happens > during sending non-linear sk_buff with .data not aligned by 4. > > Log quotation: ... > The reason: > > MPC5121 FEC requires 4-byte alignment for TX data buffer and calls > tx_skb_align_workaround() for copying sk_buff with not aligned .data to a new > sk_buff with aligned one. But tx_skb_align_workaround() uses > skb_copy_from_linear_data() which doesn't work for non-linear sk_buff: > a new sk_buff has non-zero nr_frags and zero .data_len. > > So improve the condition of calling tx_skb_align_workaround() and use > skb_linearize() in it. > > Signed-off-by: Alexander Popov Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/