Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932781AbbFWOIv (ORCPT ); Tue, 23 Jun 2015 10:08:51 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:45993 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753330AbbFWOIm (ORCPT ); Tue, 23 Jun 2015 10:08:42 -0400 Date: Tue, 23 Jun 2015 10:08:41 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Ruslan Bilovol cc: balbi@ti.com, , , , , , , Subject: Re: [PATCH v5 5/5] usb: gadget: udc-core: independent registration of gadgets and gadget drivers In-Reply-To: <1435010474-13419-6-git-send-email-ruslan.bilovol@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1687 Lines: 48 On Tue, 23 Jun 2015, Ruslan Bilovol wrote: > Change behavior during registration of gadgets and > gadget drivers in udc-core. Instead of previous > approach when for successful probe of usb gadget driver > at least one usb gadget should be already registered > use another one where gadget drivers and gadgets > can be registered in udc-core independently. > > Independent registration of gadgets and gadget drivers > is useful for built-in into kernel gadget and gadget > driver case - because it's possible that gadget is > really probed only on late_init stage (due to deferred > probe) whereas gadget driver's probe is silently failed > on module_init stage due to no any UDC added. > > Also it is useful for modules case - now there is no > difference what module to insert first: gadget module > or gadget driver one. > > Tested-by: Maxime Ripard > Signed-off-by: Ruslan Bilovol > @@ -484,6 +507,16 @@ int usb_gadget_unregister_driver(struct usb_gadget_driver *driver) > break; > } > > + if (ret) { > + struct usb_gadget_driver *tmp; > + > + list_for_each_entry(tmp, &gadget_driver_pending_list, pending) > + if (tmp == driver) { > + list_del(&driver->pending); > + ret = 0; > + break; > + } > + } Weren't you going to replace this loop with a simple list_del()? IIRC, this is the third time I have asked you to make this change. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/